Remove unused Bullet module and thirdparty code #58946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been disabled in `master` since one year (godotengine#45852) and our plan is for Bullet, and possibly other thirdparty physics engines, to be implemented via GDExtension so that they can be selected by the users who need them.
This was referenced Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been disabled in
mastersince one year (#45852) and our planis for Bullet, and possibly other thirdparty physics engines, to be
implemented via GDExtension so that they can be selected by the users
who need them.
To be clear: This is for
masteronly, Bullet is still used in the3.xbranch and there's no plan to remove it there. This PR is just a cleanup of code which was already disabled.Supersedes and closes #47508 (can be salvaged if/when someone decides to make a GDExtension port of the bullet module, which will be facilitated by upcoming GDExtension improvements by @reduz).
There's some physics APIs which were only implemented in Bullet and now are unnecessary stubs, but I kept them for now as they might still be useful for a potential GDExtension implementation, or for other physics engines. To be reviewed by @godotengine/physics and possibly changed in a follow-up. I found notably:
PhysicsDirectBodyState3D::get_contact_impulse()Shape3D::margin