Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone: Fix icon display, disable embedded windows, disable binary export, fix CI #54

Merged
merged 13 commits into from
May 28, 2022

Conversation

nikitalita
Copy link
Collaborator

We were previously importing all the Editor icons into the theme resource to load the icons in the standalone binary; Godot 4.x doesn't allow you to import the theme resource by reference any more, so we would have to manually update the theme each time, and it also massively bloats the size of that resource. Instead, we now dynamically generate them and include them in a generated header.

I also disabled binary resource conversion upon export because it is currently broken (see godotengine/godot#56185)

@lufog
Copy link
Contributor

lufog commented May 27, 2022

You can also update modules in SCONSFLAGS_TEMPLATE:

Rename module_opensimplex_enabled to module_noise_enabled (godotengine/godot#56718)
Delete module_bullet_enabled (godotengine/godot#58946)
Delete module_gdnative_enabled (godotengine/godot#58925)
Delete module_pvr_enabled (godotengine/godot#56309)
Delete module_webm_enabled (godotengine/godot#53833)

It would also be nice to disable Embed Subwindows in standalone. Because this feature does not always work well. For example:
image
The subwindow cannot be moved because the top of the window is not accessible.

@nikitalita nikitalita changed the title Fix icon display in standalone Standalone: Fix icon display, disable embedded windows, disable binary export, fix CI May 28, 2022
@nikitalita nikitalita merged commit d7f3467 into bruvzg:master May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants