Color: Bind from_hsv as static method
#54868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Nov 11, 2021
| } | ||
|
|
||
| return ret; | ||
| Color Color::from_hsv(float p_h, float p_s, float p_v, float p_alpha) { |
There was a problem hiding this comment.
The only real change here is rename p_a to p_alpha and removing const qualifier. The rest is just moving stuff around to match order in header.
4 tasks
akien-mga
force-pushed
the
color-from_hsv-static
branch
from
b9a16b4
to
e2e9b08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43311.