Core: disabled method bindings that were not compatible with the new system

[akien-mga]

Godot version:
master (424cd00)

Issue description:
#42780 changed and greatly simplified the binding system for the core API, but some problematic methods were lost in the process, as seen in #43310.

This issue lists them so that we can evaluate if they can be changed to be bound again, or if they should be dropped fully.

• Color.from_hsv(): "FIXME: Color is immutable, need to probably find a way to do this via constructor (Color: Bind from_hsv as static method #54868)
• Quat.set_axis_angle() and Quat.set_euler(): "FIXME: Quat is atomic, this should be done via constructor" (Remove Quat set methods in favour of constructors #45407)
• String.erase(): "FIXME: String needs to be immutable when binding" (String: Remove erase method, bindings can't mutate String #54869)
• String.humanize_size(): "FIXME: Static function, not sure how to bind" (Add static method support to core Variant types #46378)

The above comments come from core/variant_call.cpp, which is where core methods are bound.

[aaronfranke]

I think String.erase() should just be removed. You can already get an empty string in GDScript using String().

For Color.from_hsv(), however we bind it, we should consider changing Color8 and ColorN to be the same way.

[akien-mga]

I think String.erase() should just be removed. You can already get an empty string in GDScript using String().

That's not what it does though, it's void erase(int p_pos, int p_chars); - it removes a substring from the string.

[theoway]

I think String.erase() should just be removed. You can already get an empty string in GDScript using String().

That's not what it does though, it's void erase(int p_pos, int p_chars); - it removes a substring from the string.

#37918. We've had a discussion about this method as it goes against the point of String being immutable. We've thought of removing this method and implementing something similar to splice() as in Javascript, while making sure that String remains immutable. You can drop your suggestions on the issue mentioned above :)

[vnen]

Now that #46378 is merged, String.humanize_size() is bound. We can move Color.from_hsv() to be static too. Probably the same can be done with Quat if the constructor isn't possible.

[akien-mga]

All fixed in 1aa3c84.