Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shader editor templates to be more descriptive #51863

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Improve shader editor templates to be more descriptive #51863

merged 1 commit into from
Jul 21, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 18, 2021

This makes the shader editor more self-explanatory out of the box.

@Calinou Calinou requested a review from a team as a code owner August 18, 2021 21:56
@Calinou Calinou added this to the 4.0 milestone Aug 18, 2021
@Calinou Calinou force-pushed the shader-editor-improve-templates branch from b533dc9 to 526bf05 Compare August 18, 2021 21:57
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 9, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@Calinou Calinou force-pushed the shader-editor-improve-templates branch from 526bf05 to ff8d93a Compare July 17, 2023 09:15
@Calinou
Copy link
Member Author

Calinou commented Jul 17, 2023 •
edited
Loading

I've modified the template for fog shaders (based on the Fog shaders manual page).

@Calinou Calinou force-pushed the shader-editor-improve-templates branch 4 times, most recently from 22fc8e5 to 9c88d44 Compare July 17, 2023 10:08
@Calinou Calinou force-pushed the shader-editor-improve-templates branch from 9c88d44 to 74b63d5 Compare July 17, 2023 10:52
@Calinou Calinou force-pushed the shader-editor-improve-templates branch from 74b63d5 to 02bf74a Compare July 17, 2023 10:52
clayjohn
clayjohn approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@YuriSizov YuriSizov merged commit a3a7e1f into godotengine:master Jul 21, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@Calinou Calinou deleted the shader-editor-improve-templates branch July 21, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaosus Chaosus Chaosus left review comments

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:shaders usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @YuriSizov @Chaosus @clayjohn