Enable range coder compression by default in NetworkedMultiplayerENet (3.x) #51525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From empirical testing, this seems to provide the best compression compared to other compression algorithms when used in the Multiplayer Bomber demo. Other algorithms may provide better compression ratios for more complex games, but some compression is probably better than no compression. Zstandard was also not very efficient in my testing, so I added a note in the documentation.
|
Thanks! |
Calinou
changed the title
|
Note: This change breaks compatibility with servers and clients running Godot 3.4 beta 3 and older unless their compression mode is set to a non-default value. You can fix this by making sure clients and servers use the same Godot version, or specify a compression mode explicitly on both the client and server. See #52018 for the documentation change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.xversion of #38313. This shouldn't break compatibility with existing projects, as behavior doesn't rely on compression being enabled or not.From empirical testing, this seems to provide the best compression compared to other compression algorithms when used in the Multiplayer Bomber demo.
Other algorithms may provide better compression ratios for more complex games, but some compression is probably better than no compression.
Zstandard was also not very efficient in my testing, so I added a note in the documentation.