Cherry-picks for the 3.2 branch (future 3.2.4) - 14th batch #44795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1c546fd)
…dition ' det == 0 ' is true.) Fixes: godotengine#41873 (cherry picked from commit aba4773)
Alternative to `_change_notify()` to be called from within C++ classes. Achieves low-level consistency with scripting, where this method is exposed for updating the editor (inspector) with new values. (cherry picked from commit 9aa06c3)
They didn't show up at all in the rendered PNG, but were pretty annoying when working with Gobot face on Inkscape (cherry picked from commit 17b9cb2)
…code The code we had for PVRTexTool doesn't work as it's not compatible with current PVRTexTool CLI options, and likely hasn't been for years. Instead, we have our own vendored pvrtccompressor thirdparty library which all users have thus de-facto been using. This commit moves the compress code to `modules/pvr` where it belongs. There's no proper compress function for PVRTC 2-bit format, that's a bug that will need to be fixed (currently it's compressed as 4-bit format even if you use Image::FORMAT_PVRTC2). Fixes godotengine#28669. (cherry picked from commit 1a31274)
(cherry picked from commit cd42e93)
(cherry picked from commit 68fdd75)
See godotengine#36285 which mistakenly added documentation for the whole C++ API, while some of it is meant to be and stay private as it's not exposed to scripts. The access modifiers and method prefix were not used properly. Cleanup code, and rename wrong `group_name` parameters to `method`, as it's a method name which is being broadcast. This is a very old class from pre-open source days, chances are that it was just forgotten and not meant to be kept as is and undocumented. (cherry picked from commit 79ba70f)
(cherry picked from commit 7c0d682)
(cherry picked from commit 56e5ca3)
(cherry picked from commit ed1f208)
Should NEVER be used for precise time computations since its return values are not guaranteed to be monotonic. (cherry picked from commit 49741d9)
(cherry picked from commit 4fd2001)
This is needed with newer Mono versions, at least with Mono 6.12+ Depends on the following commit from our build scripts: godotengine/godot-mono-builds@9d75cff (cherry picked from commit b98e8b1)
- Brighten gizmos when highlighted to make the difference between a non-highlighted and a highlighted gizmo more visible. - Tweak the manipulator gizmo size property hint. (cherry picked from commit 8522ac7)
This can be used in server builds for journalctl compatibility. (cherry picked from commit 341b9cf)
…ncrypted files. (cherry picked from commit c65f097)
(cherry picked from commit fa0683e)
(cherry picked from commit ec97962)
See godotengine@8522ac7#r45230326. (cherry picked from commit 507e9b1)
Otherwise we can get situations where platform-specific opts with the same name can override each other depending on the order at which platforms are parsed, as was the case with `use_static_cpp` in Linux/Windows. Fixes godotengine#44304. This also has the added benefit that the `scons --help` output will now only include the options which are relevant for the selected (or detected) platform. (cherry picked from commit 0f84d8d)
Fixes a pre-existing bug that godotengine#44433 exposed. It's pretty hacky, but we use `platform` in `env` both as an optional command line option (instead it can be autodetected, or passed via the `p` alias, and on Linux it might be overridden if you pass one of the convenience alias values), and as the reference value for what platform we're building on. Thus we override `env_base["platform"]` with the autodetected or validated platform, but any call to `opts.Update(env_base)` overrides it with the original command line option... causing e.g. godotengine#44448. The proper fix would be to refactor all this so that we don't reuse `env["platform"]` for platform detection (it could instead be e.g. `env.platform` as a member variable which holds the validated value), but for now I'm tapering over the immediate breakage. Fixes godotengine#44448 and other breakages induced by godotengine#44433. (cherry picked from commit 8f66039)
(cherry picked from commit d6bdd04)
(cherry picked from commit 2872006)
…rmat (cherry picked from commit be1c161)
(cherry picked from commit a86ed33)
(cherry picked from commit 718227d)
(cherry picked from commit 221738f)
The blue accent color is now used, which matches the default editor accent color. It doesn't change to match the currently configured accent color automatically, but doing so would require modifying the CheckButton class a lot for little benefit. (cherry picked from commit 114c1a7)
(cherry picked from commit ed488b7)
The call was made on a `Godot` instance instead of an `Activity` instance. (cherry picked from commit 2d492ff)
(cherry picked from commit 27f964d)
Body transforms from physics are used to setup the joint and they are only updated before the physics step by default. Without forcing the transform update, joints could use a previous position if the body's position was set after it was added to the scene. 3D physics is not affected by this issue. (cherry picked from commit 11bee25)
(cherry picked from commit 709aa8a)
The logo can no longer overflow the viewport. (cherry picked from commit d802249)
(cherry picked from commit 24a6aac)
(cherry picked from commit 86aa9b1)
(cherry picked from commit 63456bd)
(cherry picked from commit 4f72a07)
A restart is required to apply the setting change. (cherry picked from commit 8221037)
See godotengine#44780. (cherry picked from commit 1dd75f4)
(cherry picked from commit 8b231af)
(cherry picked from commit d2d29c4)
akien-mga
requested review from
BastiaanOlij,
neikeq,
vnen and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.