Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradient and Color Picker checkerboard, Fix tile parameter for CanvasItem.draw_texture_rect #43158

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Fix Gradient and Color Picker checkerboard, Fix tile parameter for CanvasItem.draw_texture_rect #43158

merged 1 commit into from
Aug 9, 2021

Conversation

nathanfranke
Copy link
Contributor

@nathanfranke nathanfranke commented Oct 28, 2020 •
edited
Loading

Fix #41561
Fix #42662

image

nathanfranke
nathanfranke commented Oct 28, 2020
View reviewed changes
editor/editor_themes.cpp Outdated Show resolved Hide resolved
scene/gui/gradient_edit.cpp Outdated Show resolved Hide resolved
@nathanfranke
Copy link
Contributor Author

nathanfranke commented Oct 28, 2020 •
edited
Loading

Why is the checkerboard on the gradient ½ the size? Just using draw_texture_rect.

image

Edit: This isn't an issue anymore

@akien-mga akien-mga added this to the 4.0 milestone Oct 28, 2020
@akien-mga akien-mga requested a review from reduz October 28, 2020 12:47
@akien-mga akien-mga changed the title [4.0] Fix Gradient and Color Picker checkerboard, Fix tile parameter for CanvasItem.draw_texture_rect Fix Gradient and Color Picker checkerboard, Fix tile parameter for CanvasItem.draw_texture_rect Nov 12, 2020
reduz
reduz previously requested changes Nov 27, 2020
View reviewed changes
servers/rendering/rasterizer_rd/rasterizer_canvas_rd.cpp Outdated Show resolved Hide resolved
@gongpha gongpha mentioned this pull request Mar 1, 2021
Merged
@nathanfranke nathanfranke requested review from a team as code owners April 14, 2021 04:30
@nathanfranke
Copy link
Contributor Author

CC

this is probably unnecesary and the tile flag should be deprecated as you can change tiling in other means.

What is the best way to change tile flags for editor icons? Also, maybe this can be removed in another PR.

@akien-mga akien-mga requested a review from reduz June 8, 2021 07:39
@KoBeWi
Copy link
Member

KoBeWi commented Aug 7, 2021

Looks ok, except the removal of ColorPicker icons (check my previous comment). Also needs rebase and SNAMEs.

@nathanfranke nathanfranke force-pushed the fix-gradient-and-draw-tile branch 2 times, most recently from 2abb6e2 to b831162 Compare August 7, 2021 21:08
@akien-mga akien-mga merged commit 0a38d5c into godotengine:master Aug 9, 2021
@akien-mga
Copy link
Member

Thanks!

@nathanfranke nathanfranke deleted the fix-gradient-and-draw-tile branch August 9, 2021 15:08
@KoBeWi
Copy link
Member

KoBeWi commented Aug 9, 2021

Uh I just realized that I forgot to check if you added the SNAMEs. The icons should use
get_theme_icon(SNAME("GuiMiniCheckerboard"), SNAME("EditorIcons"))

@nathanfranke
Copy link
Contributor Author

Should I make a follow-up or can someone just make a commit for it?

@KoBeWi
Copy link
Member

KoBeWi commented Aug 9, 2021

You can make a follow-up. Someone needs to fix it anyways.

@nathanfranke nathanfranke mentioned this pull request Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@akien-mga akien-mga akien-mga approved these changes

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
bug topic:editor topic:gui topic:rendering
Projects
None yet
Milestone
4.0
4 participants
@nathanfranke @KoBeWi @akien-mga @reduz