Gradient editor displays bright magenta background instead of checker background for transparent colors

[Calinou]

Godot version: Git 7a62b94

OS/device including version: Fedora 31, GeForce GTX 1080 (NVIDIA 440.100)

Issue description:

The Gradient editor fails to display its checker background for transparent colors and will display a bright magenta color instead.

This GUI component is drawn by scene/gui/gradient_edit.cpp.

Steps to reproduce: Create a Gradient resource in the Inspector dock by using the New Resource button, then edit one of its points to have an alpha value lower than 1.0.

Minimal reproduction project: N/A

[callumW]

Hey there,

I'd like to take a crack at this no one minds?

I've got a potential fix in place but I'm not sure if it's exactly what is wanted:

I assume it would better if it matched the color picker sample area?

[Calinou]

@callumW That's a good start! Ideally, it should display a repeating checkerboard like it did in 3.2.3:

The larger the transparent area, the more repetitions you can see (like in image editors).

[callumW]

Cool, I think that would look better too. I'll take a look 😀

It looks like the color picker is a little broken too as it doesn't repeat like that, rather it displays stretched out as shown above.

Should that be raised as a separate issue or fixed in this one?

[Calinou]

@callumW What do you mean by the color picker being broken? Other than the "pick" icon being offset, I don't see any differences.

If you meant the checkerboard texture stretched instead of repeating, that's something you need to reimplement in your PR.