Implemented getsockname and poll #41600
Conversation
Calinou
added
cherrypick:3.x
|
Can you explain some possible use cases for this feature? |
|
I used for STUN NAT behavior discovery in my multiplayer implementation. |
|
@MmAaXx500 Is this still desired? If so, you should open a proposal, and this needs to be rebased and tested on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR. A proposal is also needed so that we can better evaluate what the use cases are for this feature. |
|
I will put this into a draft until #48195 is resolved. |
aaronfranke
removed
the
cherrypick:3.x
getsockname in NetSocket and EnetSocket poll in EnetSocket
|
Updated the timeout handling according to #48203. |
| @@ -63,6 +63,7 @@ class NetSocket : public Reference { | |||
| virtual Error recvfrom(uint8_t *p_buffer, int p_len, int &r_read, IP_Address &r_ip, uint16_t &r_port, bool p_peek = false) = 0; | |||
| virtual Error send(const uint8_t *p_buffer, int p_len, int &r_sent) = 0; | |||
| virtual Error sendto(const uint8_t *p_buffer, int p_len, int &r_sent, IP_Address p_ip, uint16_t p_port) = 0; | |||
| virtual Error getsockname(IP_Address &r_ip, uint16_t &r_port) = 0; | |||
There was a problem hiding this comment.
This should likely be get_socket_name. Other methods here are not snake_case, but that's a separate problem.
There was a problem hiding this comment.
And in godot.cpp too?
There was a problem hiding this comment.
Yes, this name would need to be changed in many places if it's changed on this line.
There was a problem hiding this comment.
The godot.cpp is a separate class and is in the thirdparty folder, that's why I asked.
Ok, I'll modify it tomorrow (it's late at night here).
|
Then this pr is useless, right? |
I think the only unimplemented bit there is |
Is it desirable? If so, I'll do my best in a separate pr. BTW2: Some hours ago I discovered the fact that I'm currently not using the |
Implemented
getsocknmein NetSocket and ENetSocket andpollin ENetSocketThis closes: godotengine/godot-proposals#2587