Make GLTF Scene Importer populate node metadata with GLTF extras #40474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be submitting an update with meta as an inspector on Node and Resource.
|
|
On further thought, I'm removing the meta editor to be in a separate pr. |
akien-mga
reviewed
Jul 26, 2020
7 tasks
This PR currently only generates metadata for Meshes, Cameras and Spatials. Other nodes can be added later. This feature can be enabled by a Scene Importer import option called "Meta". Co-Authored-by: Filippo Ghibellini <f.ghibellini@gmail.com>
|
This pr is salvageable but with the new GLTFState you can also grab the data directly instead of putting it in the meta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugsquad edit: Depends on #30765 which depends on #35816
This PR currently only generates metadata for Meshes, Cameras and
Spatials. Other nodes can be added later.
This feature can be enabled by a Scene Importer import option called "Meta".
This is enabled by default unlike the original 3.2 commit.
#39024