Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose "meta" to the Inspector. For real. #30765

Conversation

YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Jul 22, 2019

Second attempt. As requested by @akien-mga here: #22642 (comment).

Things that need to be worked out:

(It will, hopefully this time) Closes #5433.

@Anutrix
Copy link
Contributor

Anutrix commented Jul 23, 2019

Fixes #18591.
For some reason, 5433 and 18591 was closed. Shouldn't one of them be open.

core/object.cpp Outdated Show resolved Hide resolved
@aaronfranke
Copy link
Member

aaronfranke commented Jun 30, 2020

There is already an add-on in the Godot Asset Library which does this: https://godotengine.org/asset-library/asset/637

Does this really need to be a core feature? Maybe that add-on should be officially supported somehow?

EDIT: Actually, I do think this should be a core feature, because it's needed for some things in the engine.

@Calinou
Copy link
Member

Calinou commented Jul 1, 2020

Does this really need to be a core feature? Maybe that add-on should be officially supported somehow?

Until we have proper global plugins, I'd say "yes"... 🙁

@aaronfranke
Copy link
Member

That sounds more like a strong argument for global plugins 😆

@ghost
Copy link

ghost commented Jul 1, 2020

If meta data is an intentional feature, seems it would make sense there might be also a built in way to inspect or modify it.

@fire
Copy link
Member

fire commented Jul 17, 2020

I exposed it this way #40474 (comment) Please comment.

core/object.cpp Outdated Show resolved Hide resolved
@fire
Copy link
Member

fire commented Oct 17, 2020

I missed that #35816 is required for this. It is required.

@RichardEllicott
Copy link

RichardEllicott commented Jan 24, 2021

I missed that #35816 is required for this. It is required.

How come that is true?
The issue you link is a feature that is not normally present in Python or C# anyway (automatically comparing all the values in a dictionary?)

I really would love to access the metadata in the editor, will it be possible?

EDIT: someone linked me to addon which works great:
https://github.com/ballerburg9005/godot-metadata-inspector

@YuriSizov YuriSizov requested a review from a team August 24, 2021 22:17
@YeldhamDev YeldhamDev force-pushed the inspector_metadata_the_second_coming branch from 90f7bab to 8ba3108 Compare November 9, 2021 19:17
@YeldhamDev YeldhamDev requested review from a team as code owners November 9, 2021 19:17
@YeldhamDev YeldhamDev force-pushed the inspector_metadata_the_second_coming branch from 8ba3108 to 6c8731c Compare November 9, 2021 19:28
@KoBeWi
Copy link
Member

KoBeWi commented Jan 10, 2022

The meta property doesn't refresh when it's changed. E.g. when you toggle node's lock, it will add it to metadata, but you need to refresh the inspector manually to see it (if the property is opened).

Also I'd move the editor_description property under Metadata group, so we don't have 2 groups with single property.

I'm not convinced about usefulness of this feature though. If you want to tag some object, you can add a group or export a property. Metadata is mostly useful in scripts, to quickly pass some data etc.

@sairam4123
Copy link

I'm not convinced about usefulness of this feature though. If you want to tag some object, you can add a group or export a property. Metadata is mostly useful in scripts, to quickly pass some data etc.

I think it would be really helpful for debugging script's metadata.

@akien-mga
Copy link
Member

Superseded by #59452.

@akien-mga akien-mga closed this Mar 25, 2022
@YeldhamDev YeldhamDev deleted the inspector_metadata_the_second_coming branch March 25, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editing Node's metadata from inside the Inspector
10 participants