Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20171. #20312

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Fix #20171. #20312

merged 1 commit into from
Jul 20, 2018

Conversation

Nufflee
Copy link
Contributor

@Nufflee Nufflee commented Jul 20, 2018

The relevant line was commented out for some reason. After I removed the comment, everything works as expected.

@reduz reduz merged commit cfcb6e1 into godotengine:master Jul 20, 2018
@akien-mga akien-mga added this to the 3.1 milestone Jul 21, 2018
@akien-mga
Copy link
Member

akien-mga commented Jul 21, 2018

Thanks!

Just a note for future PRs, try to make commit logs descriptive of what they're fixing beyond a reference to the GitHub issue. Outside GitHub (e.g. in the git log locally), this log doesn't tell us anything. Something like this would have been better:

Fix connecting scalar to vector input in shader graph

Fixes #20171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants