-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exclude-entropy-patterns #192
Conversation
b7a9fe7
to
23e380d
Compare
Add the ability to exclude entropy patterns. This will allow flagged entropy rules using regular expressions for all files or specific files.
23e380d
to
5d23f93
Compare
|
This is unrelated to your changes. I've been doing some hunting and found tox-dev/tox#2077 and tox-dev/tox#1570. Unfortunately neither of those have a solution. But I have a suspicion as to what might be causing it; I added environment caching yesterday. The run that initially primed the cache passed, but subsequent runs have failed. I don't know why this would only trigger on windows/3.6, but I'm going to try digging into that separately. With that in mind, I don't think we need to consider that a blocker for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I love the new feature; this will be a huge help to our users.
I just have 2 small changes I flagged (and one that's more of a knowledge share than anything), and then we should be able to get this merged in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me.
I spent a few minutes thinking about whether it is proper to limit these exclusions only to entropy-based detection, or if instead they should be allowed to apply to regex-based alerts as well. (i.e. basically --exclude-patterns
instead of --exclude-entropy-patterns
) I can't convince myself one way or the other is obviously better, so I'd vote for letting the proposed implementation stand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦅
Add the ability to exclude entropy patterns. This will allow flagged entropy rules using regular expressions for all files or specific files.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
What's new?
exclude-entropy-patterns
option