Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFX-666] Convert generated sitemap config to ESM #798

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

jpina1-godaddy
Copy link
Contributor

@jpina1-godaddy jpina1-godaddy commented Jun 26, 2024

Summary

The sitemap config was written in common js and was throwing an error when run by an esm project. This PR converts the config file to esm.

Changelog

@gasket/plugin-nextjs

  • Convert cjs sitemap config to esm

Test Plan

  • Tested locally
image

@jpina1-godaddy jpina1-godaddy changed the base branch from main to v7 June 26, 2024 21:27
@jpina1-godaddy jpina1-godaddy changed the title Pfx 666 2 [PFX-666] Convert generated sitemap config to ESM Jun 26, 2024
@jpina1-godaddy jpina1-godaddy marked this pull request as ready for review June 26, 2024 21:36
@jpina1-godaddy jpina1-godaddy requested a review from a team as a code owner June 26, 2024 21:36
@jpina1-godaddy jpina1-godaddy merged commit 54ba52b into v7 Jul 2, 2024
1 check passed
@jpina1-godaddy jpina1-godaddy deleted the pfx-666-2 branch July 2, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants