Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Initial plugins support #1041

Merged
merged 9 commits into from
May 29, 2024
Merged

[Go] Initial plugins support #1041

merged 9 commits into from
May 29, 2024

Conversation

aka-bo
Copy link
Contributor

@aka-bo aka-bo commented Apr 26, 2024

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

What's new?

DynamoDB based implementations of the appencryption.KeyManagementService and appencryption.Metastore interfaces have been relocated to the new plugins directory as follows:

  • pkg/kms => plugins/aws-v1/kms
  • pkg/persistence => plugins/aws-v1/persistence

Type declarations in the original pkg/kms and pkg/persistence packages have been replaced with aliases (and wrapper functions) to maintain backwards compatibility. Note that these alias types have all been marked as deprecated and will be removed in a future version.

Bumped version to v0.5.0

@aka-bo aka-bo marked this pull request as ready for review May 16, 2024 17:34
@aka-bo aka-bo requested a review from sushantmimani May 16, 2024 17:35
Copy link
Contributor

@sushantmimani sushantmimani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sushantmimani sushantmimani merged commit 04b09ad into godaddy:main May 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants