Introduce a script and a Github workflow to ensure our WooCommerce templates are always up to date with the latest version. #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eherman-godaddy
changed the title
jbardo-godaddy
requested changes
Mar 9, 2023
|
@eherman-godaddy Brilliant! Good on you to takle that |
|
@eherman-godaddy anyway you think of we could run this on Github action instead of locally? |
|
@jbardo-godaddy Yeah, this whole workflow should only run on any changes to master https://github.com/godaddy-wordpress/go/pull/847/files#diff-c8ffdf393c0c7fca38f0c86f5ee054bdc4f57947b291bdc5fcfc25a5998a50b5R1-R40 |
Sorry I miss that. LGTM then |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a way to automate the process of keeping the WooCommerce cart.php template files version, that we bundle, up to date. This script reaches out to the WooCommerce template file on Github and compares our bundled template version to the most up to date one. If the version on the WooCommerce github is greater than the one we bundle, our Github workflow will bump the version in the bundled template and commit it back to Github, ensuring that our template version always matches the most up to date one on Github.
npm run update:woo-template-versions.mastervia this workflow, update the template file (if needed) and then commit the updated file back to Github.