Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WooCommerce saved payment method radio button visibility #834

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

EvanHerman
Copy link
Contributor

image

@EvanHerman EvanHerman added [Priority] High This issue/pull request needs resolving before the next release [Type] Woo Relevant to WooCommerce labels Jan 5, 2023
@EvanHerman EvanHerman self-assigned this Jan 5, 2023
@AnthonyLedesma
Copy link
Member

In my testing, these styles here are still conflicting with the display of the saved payment methods. Here is what I see with your updated styles in place.

What I see:
image

Conflicting styles:

input[type="radio"],
input[type="checkbox"] {
height: 19px;
opacity: 0;
width: 20px;
}

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles still seem to have a conflict.

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, there we go. I had some cache styles or something hanging out. When I forced the new style sheet in place things are looking proper!
Screen Shot 2023-01-17 at 10 00 45 AM

@EvanHerman EvanHerman merged commit a80e072 into master Jan 17, 2023
@EvanHerman EvanHerman deleted the fix-woocommerce-saved-payments branch January 17, 2023 19:30
@AnthonyLedesma AnthonyLedesma added this to the 1.7.4 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High This issue/pull request needs resolving before the next release [Type] Woo Relevant to WooCommerce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants