Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build path to images #746

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Fix build path to images #746

merged 2 commits into from
Jan 18, 2022

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Jan 18, 2022

The webkit config was altered when we migrated to yarn and the images paths were not being set correct in the dist directory after a build. This PR fixes it so images appear in the expected directories in dist/images/.

@EvanHerman EvanHerman self-assigned this Jan 18, 2022
@EvanHerman EvanHerman added the [Priority] High This issue/pull request needs resolving before the next release label Jan 18, 2022
@EvanHerman EvanHerman added this to the Next Release milestone Jan 18, 2022
@godaddy-wordpress-bot
Copy link
Contributor

@cypress
Copy link

cypress bot commented Jan 18, 2022



Test summary

5 0 0 0


Run details

Project Go
Status Passed
Commit 0779561
Started Jan 18, 2022 8:40 PM
Ended Jan 18, 2022 8:46 PM
Duration 05:41 💡
OS Linux Debian - 11.1
Browser Chrome 95

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jrtashjian jrtashjian merged commit 87a27a0 into master Jan 18, 2022
@jrtashjian jrtashjian deleted the fix-build-images branch January 18, 2022 21:28
@EvanHerman EvanHerman modified the milestones: Next Release, 1.5.2 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High This issue/pull request needs resolving before the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants