Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles to prevent override of user set text color #696

Merged
merged 22 commits into from
Oct 13, 2021

Conversation

AnthonyLedesma
Copy link
Member

Tested against Alert, Hero, Cover, Accordion, Highlight. No regression was detected.

Custom color in editor
image

Custom color on front-end (bug)
image

With this bug fix in place, custom colors will persist on the front-end and editor.

@AnthonyLedesma AnthonyLedesma added the [Type] Bug Something that is not working as expected label Sep 30, 2021
@AnthonyLedesma AnthonyLedesma self-assigned this Sep 30, 2021
@cypress
Copy link

cypress bot commented Sep 30, 2021



Test summary

14 0 0 0


Run details

Project Go
Status Passed
Commit d9340b7
Started Oct 13, 2021 8:36 PM
Ended Oct 13, 2021 8:38 PM
Duration 01:38 💡
OS Linux Debian - 11.0
Browser Chrome 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well on my end. Good job on the build fixes. Well just want to remove the package-lock.json file, since that was remove here #697 👍

@jonathanbardo jonathanbardo merged commit 5f83d2a into master Oct 13, 2021
@jonathanbardo jonathanbardo deleted the fix/shared-text-color branch October 13, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants