Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target=_blank to social media links #626

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Add target=_blank to social media links #626

merged 2 commits into from
Jan 6, 2021

Conversation

vilocity-brian
Copy link
Contributor

@vilocity-brian vilocity-brian commented Dec 20, 2020 •
edited by richtabor
Loading

Closes #625

@richtabor
Copy link
Contributor

Good stuff Brian, much appreciated!

I added screen reader advanced warnings for the icons (per WCAG).

Ex:
Screen Shot 2021-01-06 at 1 47 37 PM

EvanHerman
EvanHerman approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is working well on my end. 👍

Nice catch on the a11y.

@EvanHerman EvanHerman merged commit 2c19d79 into godaddy-wordpress:master Jan 6, 2021
@EvanHerman EvanHerman added [Type] Enhancement Something new that adds functionality [Type] a11y Issues/PRs related to accessibility labels Jan 21, 2021
@EvanHerman EvanHerman added this to the 1.4.0 milestone Jan 21, 2021
@EvanHerman EvanHerman modified the milestones: 1.4.0, 1.4.1 Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHerman EvanHerman EvanHerman approved these changes

Assignees

@richtabor richtabor

@vilocity-brian vilocity-brian

Labels
[Type] a11y Issues/PRs related to accessibility [Type] Enhancement Something new that adds functionality
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

Social Media Links open in same window
3 participants
@vilocity-brian @richtabor @EvanHerman