Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape the icon href attribute #2594

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Escape the icon href attribute #2594

merged 1 commit into from
Mar 11, 2024

Conversation

EvanHerman
Copy link
Contributor

Description

Escape icon block href attribute.

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Checklist:

  • My code is tested
  • I've added proper labels to this pull request

@EvanHerman EvanHerman added the [Priority] High This issue/pull request needs resolving before the next release label Mar 11, 2024
@EvanHerman EvanHerman added this to the Next Release milestone Mar 11, 2024
@EvanHerman EvanHerman self-assigned this Mar 11, 2024
@EvanHerman EvanHerman marked this pull request as ready for review March 11, 2024 14:27
@EvanHerman EvanHerman modified the milestones: Next Release, 3.1.7 Mar 11, 2024
Copy link
Member

@olafleur-godaddy olafleur-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it and it fixes the issue. Thanks!

@EvanHerman EvanHerman merged commit 2622dc1 into master Mar 11, 2024
48 checks passed
@EvanHerman EvanHerman deleted the esc-icon-url branch March 11, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High This issue/pull request needs resolving before the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants