Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Labs and Settings modals compatible with Gutenberg >=14.3.0 #2473

Merged

Conversation

WunderBart
Copy link
Contributor

@WunderBart WunderBart commented Jan 25, 2023

Fixes #2474

Description

Fix a regression where the Editor settings and CoBlocks Labs modals render empty for Gutenberg versions >=14.3.0. The breaking change was introduced in WordPress/gutenberg#44642).

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  1. Checkout this branch,

  2. wp-env start && yarn start,

  3. Make sure the Gutenberg plugin is not installed (the trunk version is active),

  4. Go to a new post page,

  5. Click the three dots menu in the top right corner,

  6. Click Editor settings and CoBlocks Labs and make sure they render correctly,

    Editor settings modal CoBlocks Labs modal
    Screenshot 2023-01-25 at 12 45 50 Screenshot 2023-01-25 at 12 45 59
  7. Install and activate the latest Gutenberg plugin (v15.0.1 at the time of writing),

  8. Repeat steps 4-6,

  9. Checkout master branch,

  10. Repeat steps 4-6, but now both modals should render broken:

    Editor settings modal CoBlocks Labs modal
    Screenshot 2023-01-25 at 12 45 25 Screenshot 2023-01-25 at 12 45 34

Acceptance criteria

Both modals should be compatible with the latest and trunk version of Gutenberg.

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent changes. Thank you very much for making these changes @WunderBart. Tested and working well.

@AnthonyLedesma AnthonyLedesma merged commit 7eac261 into godaddy-wordpress:master Feb 14, 2023
@WunderBart WunderBart deleted the fix/settings-modal branch February 15, 2023 09:32
@WunderBart
Copy link
Contributor Author

Excellent changes. Thank you very much for making these changes @WunderBart. Tested and working well.

Thank you, @AnthonyLedesma! 🙌 Do you know if it will land in a patch release anytime soon?

@AnthonyLedesma AnthonyLedesma added this to the 3.0.1 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISBAT use Settings and Labs modals with Gutenberg >=14.3.0
2 participants