Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong a function name in abstract.llms.admin.table.php #2469

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

kamalahmed
Copy link
Contributor

Description

There is a typo in the function name called is_strinp() in admin table file and I have fixed it.
Location: https://github.com/gocodebox/lifterlms/blob/trunk/includes/abstracts/abstract.llms.admin.table.php#L335C14-L335C23

It is a safe change.

Types of changes

It fixes a typo in a php builtin function. It is a safe change.

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@eri-trabiccolo
Copy link
Collaborator

@kamalahmed
Thanks for this!

I'm just going to add some required things and change the target branch from trunk to dev (see https://github.com/gocodebox/lifterlms/blob/trunk/.github/CONTRIBUTING.md#contributing-code)

@eri-trabiccolo eri-trabiccolo self-requested a review June 26, 2023 15:53
@eri-trabiccolo eri-trabiccolo changed the base branch from trunk to dev June 27, 2023 06:58
@eri-trabiccolo eri-trabiccolo merged commit 24302ef into gocodebox:dev Jun 27, 2023
18 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants