Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalize complete acronym if it is first segment of pascalized ident #39

Closed
breml opened this issue Apr 6, 2020 · 1 comment · Fixed by #51
Closed

Capitalize complete acronym if it is first segment of pascalized ident #39

breml opened this issue Apr 6, 2020 · 1 comment · Fixed by #51

Comments

@breml
Copy link
Contributor

breml commented Apr 6, 2020

If the first segment of an ident is an acronym, only the first letter gets capitalized in method Pascalize.

e.g. ip_address is pascalized to IpAddress, I expected to get IPAddress.

For public types in Go, go lint complains, if e.g. ip is not capitalized to IP.
breml added a commit to breml/flect that referenced this issue Apr 6, 2020
@breml
Capitalize complete acronym if it is first segment
c65858d 
in pascalized ident

Fixes gobuffalo#39
@breml breml mentioned this issue Apr 6, 2020
Closed
breml added a commit to breml/flect that referenced this issue Apr 6, 2020
@breml
Capitalize complete acronym if it is first segment
3e2b7c3 
in pascalized ident

Fixes gobuffalo#39
@breml breml mentioned this issue Apr 6, 2020
Closed
@sio4 sio4 linked a pull request Mar 12, 2022 that will close this issue
Capitalize complete acronym if it is first segment - improved #51
Merged
sio4 pushed a commit that referenced this issue Mar 12, 2022
@breml @sio4
Capitalize complete acronym if it is first segment
3fade60 
in pascalized ident

Fixes #39
@sio4 sio4 closed this as completed in e28b95b Mar 12, 2022
@sio4
Copy link
Member

sio4 commented Mar 12, 2022 •
edited
Loading

Thanks for bringing this issue and fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sio4 @breml