Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the value of CilType.Location.Byte to -1 if missing in JSON #1563

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

karoliineh
Copy link
Member

While refactoring some GobPie's classes to records, I accidentally removed a seemingly unused field

@SerializedName("byte")
private static int startByte = -1;

from the GoblintLocation class.

This made Goblint crash when using breakpoints for which the requests are done using Location.
Instead of putting the field back into GobPie, we decided to fix it in Goblint, as the of_yojson of a location is anyways only used by GobPie.

@karoliineh karoliineh marked this pull request as ready for review August 23, 2024 09:31
@sim642 sim642 added this to the v2.5.0 milestone Aug 26, 2024
@sim642 sim642 merged commit f27ae52 into master Aug 26, 2024
21 checks passed
@sim642 sim642 deleted the location_of_yojson branch August 26, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants