Exit after usage() is shown. Fixes #3583 #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
loafoe
commented
Sep 4, 2024
•
loafoe
commented
- Fixes panics
- Resolves Deepsource finding about extra block
loafoe
force-pushed
the
v3
branch
2 times, most recently
from
11acbb0
to
6503d1a
Compare
|
Nice, thank you for the fix! It looks like somehow that broke some tests, would you mind taking a look? You can run tests locally by running |
|
@raphael test should be fixed now 👍🏻 |
loafoe
force-pushed
the
v3
branch
2 times, most recently
from
b6cbe90
to
6e64301
Compare
Signed-off-by: Andy Lo-A-Foe <andy.loafoe@gmail.com>
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.