Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deployment): use server API types for deployment #1197

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

ecrupper
Copy link
Contributor

Continuing the efforts to migrate from the types repo and also augment API responses.

This should be the last resource that we augment. The rest will stay slim (step, log, etc.)

@ecrupper ecrupper requested a review from a team as a code owner September 30, 2024 16:49
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 88.85246% with 34 lines in your changes missing coverage. Please review.

Project coverage is 53.78%. Comparing base (23e4c60) to head (b27bae7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scm/github/deployment.go 22.22% 7 Missing ⚠️
api/types/deployment.go 96.26% 5 Missing ⚠️
database/deployment/opts.go 0.00% 4 Missing ⚠️
database/types/deployment.go 95.00% 3 Missing and 1 partial ⚠️
mock/server/deployment.go 0.00% 4 Missing ⚠️
api/webhook/post.go 0.00% 3 Missing ⚠️
database/types/build.go 57.14% 2 Missing and 1 partial ⚠️
api/deployment/create.go 0.00% 2 Missing ⚠️
database/deployment/get.go 81.81% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   53.05%   53.78%   +0.72%     
==========================================
  Files         559      561       +2     
  Lines       19747    19950     +203     
==========================================
+ Hits        10477    10730     +253     
+ Misses       8701     8646      -55     
- Partials      569      574       +5     
Files with missing lines Coverage Δ
api/types/build.go 99.11% <ø> (+7.34%) ⬆️
database/build/count_deployment.go 100.00% <100.00%> (ø)
database/deployment/create.go 84.61% <100.00%> (ø)
database/deployment/delete.go 100.00% <100.00%> (ø)
database/deployment/deployment.go 52.63% <ø> (ø)
database/deployment/get_repo.go 83.78% <100.00%> (+33.78%) ⬆️
database/deployment/list.go 82.85% <100.00%> (+36.19%) ⬆️
database/deployment/list_repo.go 86.04% <100.00%> (+28.15%) ⬆️
database/deployment/update.go 84.61% <100.00%> (ø)
database/resource.go 78.72% <100.00%> (+0.15%) ⬆️
... and 13 more

@wass3rw3rk
Copy link
Member

wass3rw3rk commented Oct 1, 2024

i would like to see a PR on go-vela/types to annotate the legacy Deployment type as deprecated as we've done with the other types we've moved already

@ecrupper ecrupper merged commit 79667fd into main Oct 2, 2024
14 of 16 checks passed
@ecrupper ecrupper deleted the refactor/nested-api/deployment branch October 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants