Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/dashboards): return empty list #1185

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix(api/dashboards): return empty list #1185

merged 2 commits into from
Sep 17, 2024

Conversation

wass3rw3rk
Copy link
Member

when there are no dashboards we currently return 'null'. this change will return an empty list instead

when there are no dashboards we currently return 'null'. this change
will return an empty list instead
@wass3rw3rk wass3rw3rk requested a review from a team as a code owner September 16, 2024 19:41
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (809af2a) to head (c5d500c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/dashboard/list_user.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   53.05%   53.05%           
=======================================
  Files         559      559           
  Lines       19740    19740           
=======================================
  Hits        10473    10473           
  Misses       8699     8699           
  Partials      568      568           
Files with missing lines Coverage Δ
api/dashboard/list_user.go 0.00% <0.00%> (ø)

@wass3rw3rk wass3rw3rk merged commit 7e606ab into main Sep 17, 2024
11 of 12 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/api/dashboards branch September 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants