Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add a status call for failed compilation #1178

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ecrupper
Copy link
Contributor

This will greatly ease the amount of sleuthing users have to do when they don't see a Vela status show up on their PR / commit.

Further, the context URL will point to the hooks page, which should take users right to the error message.

@ecrupper ecrupper requested a review from a team as a code owner September 11, 2024 14:16
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (e0c2f7e) to head (c07d416).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scm/github/repo.go 0.00% 5 Missing ⚠️
api/webhook/post.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
- Coverage   52.81%   52.79%   -0.03%     
==========================================
  Files         551      551              
  Lines       19211    19219       +8     
==========================================
  Hits        10146    10146              
- Misses       8501     8509       +8     
  Partials      564      564              
Files with missing lines Coverage Δ
api/webhook/post.go 0.00% <0.00%> (ø)
scm/github/repo.go 75.69% <0.00%> (-0.86%) ⬇️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 6750763 into main Sep 11, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the enhance/scm-status-on-compile-error branch September 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants