Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): add active status on repo partial #1119

Merged
merged 2 commits into from
May 6, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 3, 2024

If someone disables a repo that is attached to a dashboard, the UI can interpret the active status to display a message of some kind.

@ecrupper ecrupper requested a review from a team as a code owner May 3, 2024 14:17
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@38cd714). Click here to learn what that means.

❗ Current head e6edbfe differs from pull request most recent head 8c3f3c7. Consider uploading reports for the commit 8c3f3c7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1119   +/-   ##
=======================================
  Coverage        ?   67.75%           
=======================================
  Files           ?      391           
  Lines           ?    13034           
  Branches        ?        0           
=======================================
  Hits            ?     8831           
  Misses          ?     3696           
  Partials        ?      507           
Files Coverage Δ
api/types/dashboard.go 100.00% <ø> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 993a937 into main May 6, 2024
10 of 11 checks passed
@ecrupper ecrupper deleted the fix/dashboard/repo-active-partial branch May 6, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants