Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployments): set deployment created event action #1087

Merged
merged 9 commits into from
Apr 11, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Mar 19, 2024

adding support for event: [deployment:created]
depends on: go-vela/types#365

reference: https://go-vela.github.io/docs/usage/repo_settings/#webhook-events

go.mod Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.47%. Comparing base (4fea679) to head (589b45c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files         370      370           
  Lines       11788    11790    +2     
=======================================
+ Hits         7600     7602    +2     
  Misses       3671     3671           
  Partials      517      517           
Files Coverage Δ
scm/github/webhook.go 90.90% <100.00%> (+0.05%) ⬆️

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit ed4ab24 into main Apr 11, 2024
11 of 13 checks passed
@plyr4 plyr4 deleted the fix/deployment-created branch April 11, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants