Add a dont_clean option #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case with a very large (85+ GiB, 20+ layers) dataset with small features that only need to be served on one zoom level. "Small" means that the features are usually not bigger than 1 tile in the single zoomlevel that they are served on. The features in the dataset are validated beforehand (self intersecting, etc). Clipping, simplifying and cleaning/validating are not necessary in our case, and disabling them increases performance. Especially cleaning takes a lot of processing time, which takes the response time above a workable threshold for this dataset. (Especially when clipping is disabled, but that's a known issue, I believe.)
tl;dr: an option to disable cleaning/making valid