Drop go-bindata dependency #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bindata has been removed as the tooling for embedding the UI in favor of using Go's native embed package.
Pull Request Test Coverage Report for Build 114c3feb6-PR-843
💛 - Coveralls |
Moved away from build.Import as it was not finding the package when given the sourceDirectory directly. Something has changed in the API, not sure what. Using the `go list` command instead. This is fine as we where depending on it already to get the list of all the packages in a repository. So, not we use it to get the source directory for a package and the packages Name. This is then used with `build.ImportDir` to get the full information about the package.
This was referenced Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.