Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement set repr #117

Merged
merged 6 commits into from
Oct 14, 2019
Merged

Implement set repr #117

merged 6 commits into from
Oct 14, 2019

Conversation

xarus01
Copy link
Contributor

@xarus01 xarus01 commented Oct 8, 2019

Fix #85

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #117 into master will increase coverage by 0.01%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   72.84%   72.85%   +0.01%     
==========================================
  Files          60       60              
  Lines       11935    11949      +14     
==========================================
+ Hits         8694     8706      +12     
- Misses       2708     2709       +1     
- Partials      533      534       +1
Impacted Files Coverage Δ
py/range_repr110.go 70% <ø> (ø) ⬆️
builtin/builtin.go 80.21% <100%> (ø) ⬆️
py/range.go 86.66% <100%> (ø) ⬆️
py/set.go 76.19% <85.71%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33327c5...12fe2c0. Read the comment docs.

py/tests/set.py Show resolved Hide resolved
builtin/testfile Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Collaborator

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please resolve the conflict
  2. There are some codes that are not related to Implement set repr #85, please revert them.

Thank you :0

@xarus01 xarus01 requested a review from corona10 October 10, 2019 09:10
Copy link
Collaborator

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 merged commit 0c23b14 into go-python:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement set repr
4 participants