Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log CloudWatch response error #961

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Log CloudWatch response error #961

merged 2 commits into from
Feb 24, 2020

Conversation

taraspos
Copy link
Contributor

Condition to log CloudWatch Response Error is broken, as a result, the error is never logged.
This PR fixes the condition

@peterbourgon
Copy link
Member

Thanks. Is it possible to write a test which failed on the previous behavior and works with the fixed behavior?

@taraspos
Copy link
Contributor Author

@peterbourgon done!

@peterbourgon peterbourgon merged commit fb88150 into go-kit:master Feb 24, 2020
@peterbourgon
Copy link
Member

Thank you!

@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants