New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary error check. #581

Merged

ChrisHines merged 1 commit into go-kit:master from cam-stitt:logger-marshaler-error

Jul 20, 2017

Contributor

cam-stitt commented Jul 20, 2017 •

edited

Loading

If you want to see the test fail, just add the error interface in the test without removing the error type check.


          Remove unnecessary error check.

7e2c58b

ChrisHines merged commit e10f5bf into go-kit:master

Member

ChrisHines commented Jul 20, 2017

Perfect. Thanks!

Fixes #580.

ChrisHines mentioned this pull request

JSONLogger let's error interface take priority over json.Marshaler #580

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet