Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: distinguish between Unique and UniqueIndex #106

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

black-06
Copy link
Contributor

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

See go-gorm/gorm#6381.

based on go-gorm/gorm#6386

User Case Description

@black-06 black-06 requested a review from a631807682 June 19, 2023 11:53
@black-06
Copy link
Contributor Author

I have a problem, When an index or constraint depends on the column,
this column cannot exec ALTER. See https://stackoverflow.com/questions/19460912/the-object-df-is-dependent-on-column-changing-int-to-double/19461205#19461205

Our driver doesn't seem to think about it. What should I do? @a631807682

Copy link
Member

@a631807682 a631807682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestMigrateWithUniqueIndexAndUnique seems failed in sqlserver?

Sorry, I didn't see the comment, I'll check it out

@a631807682
Copy link
Member

I have a problem, When an index or constraint depends on the column, this column cannot exec ALTER. See stackoverflow.com/questions/19460912/the-object-df-is-dependent-on-column-changing-int-to-double/19461205#19461205

Our driver doesn't seem to think about it. What should I do?

In this case, we need to modify the constraint or index first, but since we didn't support it before, we don't need to support it in this PR (may need to create another PR to fix it)

@black-06
Copy link
Contributor Author

black-06 commented Feb 5, 2024

It still has some problems which I'm fixing

After testing, it works well with go-gorm/gorm#6822

@jinzhu jinzhu merged commit ef8f762 into go-gorm:master Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants