Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: distinguish between Unique and UniqueIndex #195

Merged
merged 1 commit into from
Feb 4, 2024
Merged

refactor: distinguish between Unique and UniqueIndex #195

merged 1 commit into from
Feb 4, 2024

Conversation

black-06
Copy link
Contributor

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

See go-gorm/gorm#6381.

tested with go-gorm/gorm#6386

User Case Description

@black-06 black-06 requested a review from a631807682 June 15, 2023 08:56
a631807682
a631807682 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@a631807682 a631807682 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on gorm's PR, this is a breaking change, releases need to pay attention to the version number.

@jinzhu jinzhu merged commit 1cfbc86 into go-gorm:master Feb 4, 2024
jasonchuan added a commit to jasonchuan/postgres that referenced this pull request Feb 4, 2024
@jasonchuan
Revert "refactor: distinguish between Unique and UniqueIndex (go-gorm…
477fb71 
…#195)"

This reverts commit 1cfbc86.
@jasonchuan jasonchuan mentioned this pull request Feb 4, 2024
Closed
@black-06 black-06 mentioned this pull request Feb 4, 2024
Merged
3 tasks
@mi6e4ka mi6e4ka mentioned this pull request Feb 4, 2024
Closed
@black-06 black-06 mentioned this pull request Feb 5, 2024
Merged
3 tasks
@black-06
Copy link
Contributor Author

black-06 commented Feb 5, 2024

we need to revert the #195 relative code first, both in postgress and gorm. @black-06

because its breaking change？
But we have to do/fix this sooner or later

@jasonchuan
Copy link
Contributor

ok let's try to fix it

@black-06
Copy link
Contributor Author

black-06 commented Feb 5, 2024

ok let's try to fix it

yes I'm doing 😰

@black-06 black-06 mentioned this pull request Feb 6, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a631807682 a631807682 a631807682 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@black-06 @jasonchuan @a631807682 @jinzhu