Fixed repo link in generated comment for cross repository dependency #9863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncy, before links assumed the issue was in the same repository. also changed the format of the displayed issue since the issue will not necessarily be in the same repo
|
Before: After: |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #9863 +/- ##
=========================================
Coverage ? 42.29%
=========================================
Files ? 607
Lines ? 79356
Branches ? 0
=========================================
Hits ? 33565
Misses ? 41650
Partials ? 4141
Continue to review full report at Codecov.
|
guillep2k
reviewed
Jan 19, 2020
lunny
reviewed
Jan 19, 2020
…her the issue url, and added an if statement around the issue link display as a nil protection
|
And I think maybe you should add |
Merged
guillep2k
approved these changes
Jan 20, 2020
GiteaBot
added
lgtm/need 1
6543
reviewed
Jan 20, 2020
| {{if .DependentIssue}} | ||
| <div class="detail"> | ||
| <span class="octicon octicon-plus"></span> | ||
| <span class="text grey"><a href="{{.DependentIssue.HTMLURL}}">{{.DependentIssue.Repo.FullName}}#{{.DependentIssue.Index}} - {{.DependentIssue.Title}}</a></span> |
There was a problem hiding this comment.
If current repo != dependentissue.repo ...
zeripath
approved these changes
Jan 21, 2020
GiteaBot
added
lgtm/done
6543
approved these changes
Jan 21, 2020
|
Make lg-tm work |
|
Please send backport |
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Jan 22, 2020
…o-gitea#9863) * fixed link to issue in issue comments after adding/removing a dependency, before links assumed the issue was in the same repository. also changed the format of the displayed issue since the issue will not necessarily be in the same repo * based on pr comments, changed to use HTMLURL instead of piecing together the issue url, and added an if statement around the issue link display as a nil protection * only showing repo name in dependency comment if the issue is from another repo Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
|
created bakport for you @bhalbright (#9935) |
lafriks
pushed a commit
that referenced
this pull request
Jan 22, 2020
…9863) (#9935) * fixed link to issue in issue comments after adding/removing a dependency, before links assumed the issue was in the same repository. also changed the format of the displayed issue since the issue will not necessarily be in the same repo * based on pr comments, changed to use HTMLURL instead of piecing together the issue url, and added an if statement around the issue link display as a nil protection * only showing repo name in dependency comment if the issue is from another repo Co-authored-by: Brad Albright <32200834+bhalbright@users.noreply.github.com> Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
Thanks @6543 I wasn't going to have time this week, appreciate it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #9765. When adding or removing a dependency, a comment is generated on each issue. The comment when displayed in the UI assumes that the issue is in the same repository, but with cross repository dependencies, they are not. Fixed to show the full name of the issue and links to the correct issue.