Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the rev-parsed sha1 commit id #98

Merged
merged 1 commit into from
Nov 6, 2016

Conversation

odinuge
Copy link
Contributor

@odinuge odinuge commented Nov 6, 2016

Use the rev-parsed sha1 commit id in urls to repo files,
instead of the abbreved version.

Now, the urls to the repo-files contains the abbreviated version of the commits sha1sum, resulting in a 404, due to a lacking implementation of the route /:user/:repo/src/:sha/.

Use the rev-parsed sha1 commit id in urls to repo files,
instead of the abbreviated version.
@codecov-io
Copy link

codecov-io commented Nov 6, 2016

Current coverage is 2.24% (diff: 100%)

Merging #98 into master will not change coverage

@@            master       #98   diff @@
========================================
  Files           32        32          
  Lines         7521      7521          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           169       169          
  Misses        7335      7335          
  Partials        17        17          

Powered by Codecov. Last update 92c48da...0962a07

@strk strk added the type/bug label Nov 6, 2016
@strk strk added this to the 1.0.0 milestone Nov 6, 2016
@strk
Copy link
Member

strk commented Nov 6, 2016

LGTM, fixes the "View file" link when accessing a commit via short sha

@andreynering
Copy link
Contributor

LGTM

@andreynering andreynering merged commit 5a6f7ed into go-gitea:master Nov 6, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 5, 2017
lunny added a commit to lunny/gitea that referenced this pull request Feb 7, 2019
* fix retrieve file last commit branchName

* fix test

* fix the commit cache and git log with specify branch or commit

* remove unused lock
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants