Send tag create and push webhook when release created on UI #8325

blueworrybear · 2019-09-30T14:16:48Z

This pull request is to fix #5288 and #6027

This update will send both tag create and push event after release created.
Since the release creation creates a new tag in git repository, it seems to me that it makes sense to send tag create and push event.

codecov-io · 2019-09-30T14:38:22Z

Codecov Report

Merging #8325 into master will decrease coverage by 0.09%.
The diff coverage is 42.09%.

@@            Coverage Diff            @@
##           master    #8325     +/-   ##
=========================================
- Coverage   41.76%   41.67%   -0.1%     
=========================================
  Files         496      530     +34     
  Lines       65585    68635   +3050     
=========================================
+ Hits        27391    28601   +1210     
- Misses      34680    36371   +1691     
- Partials     3514     3663    +149

Impacted Files	Coverage Δ
models/migrations/v60.go	`0% <ø> (ø)`	⬆️
models/migrations/v65.go	`0% <ø> (ø)`	⬆️
models/commit_status.go	`66.32% <ø> (ø)`	⬆️
models/attachment.go	`51% <ø> (ø)`	⬆️
models/migrations/v88.go	`0% <ø> (ø)`	⬆️
models/migrations/v45.go	`0% <ø> (ø)`	⬆️
models/migrations/v79.go	`0% <ø> (ø)`	⬆️
models/issue_tracked_time.go	`67.56% <ø> (ø)`	⬆️
models/migrations/v74.go	`0% <ø> (ø)`	⬆️
models/migrations/v21.go	`0% <ø> (ø)`	⬆️
... and 278 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09bcc9e...13bf498. Read the comment docs.

go.mod

lunny · 2019-09-30T14:41:13Z

I think push should be handler by post-receive.

blueworrybear · 2019-09-30T14:50:52Z

I think push should be handler by post-receive.

I'll take a look if I could handle the webhook on post-receive.

blueworrybear · 2019-10-01T16:15:00Z

@lunny
I have update to go V1.13. But I'm not sure if push could be handled by post-receive.
The tag for release is created directly in the remote repository. Therefore there is no git push during release creation actually.

Therefore, I would like to keep the codes. If there is any misunderstanding, please let me know.
Thanks for your help. 😄

* [arc-green] white on hover for active menu items Actually, hovered active menu elements are in an unreadable black text colour. This should be changed to white. * [arc-green] white on hover for active menu items Actually, hovered active menu elements are in an unreadable black text colour. This should be changed to white. Now editing less files and commiting with `make css`.

…tc.) (go-gitea#7756) * Add API for Repo Advanced Settings of wiki and issue tracker Signed-off-by: David Svantesson <davidsvantesson@gmail.com> * Add some integration tests for tracker and wiki settings through API * Should return StatusUnprocessableEntity in case of invalid API values. * Add tests for invalid URLs for external tracker and wiki. * Do not set inital values if they are default of type * Make issue tracker and wiki units separate structures in Repository API structure. Signed-off-by: David Svantesson <davidsvantesson@gmail.com> * Fix comment of structures Signed-off-by: David Svantesson <davidsvantesson@gmail.com> * Rewrite API to use struct for setting tracker and wiki settings. * LetOnlyContributorsTrackTime -> AllowOnlyContributorsToTrackTime

* upgrade xorm to v0.7.9 to fix some bugs * upgrade xormstore to v1.3.1

…gitea#8307) * Revert go-gitea#7898 * Transaction-aware retry create issue to cope with duplicate keys * Restore INSERT ... WHERE usage * Rearrange code for clarity * Fix error return in newIssue() * Fix error message

* Add test for FilterModeMention * Fix column name ambiguity * Fix fmt

* Extend time window for TestAPILFSLocksLogged

fixes go-gitea#8299, a regression from 867f46f. unlike it's name suggests, the .markdown class is needed for most markup types. a future refactor should rename this class to something more generic

…rams (go-gitea#8528) * Expose db.SetMaxOpenConns and allow other dbs to set their connection params * Add note about port exhaustion Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

…itea#8612) * More information for drone-cli in CONTRIBUTING.md * Increases the version of drone-cli to 1.2.0 * Adds a note for the Docker Toolbox on Windows Signed-off-by: LukBukkit <luk.bukkit@gmail.com> * Fix the url for the blog repository (now on gitea.com) Signed-off-by: LukBukkit <luk.bukkit@gmail.com>

* static url * add cors support for static resources * [assets] work on the migration to configurable url for assets Signed-off-by: Jakob Ackermann <das7pad@outlook.com> * [misc] fix whitespace Signed-off-by: Jakob Ackermann <das7pad@outlook.com> * [assets] fix the loading of the manifest.json It is generated dynamically, and as such can not be served by the cdn. Signed-off-by: Jakob Ackermann <das7pad@outlook.com> * Revert "add cors support for static resources" This reverts commit 42f964f Signed-off-by: Jakob Ackermann <das7pad@outlook.com> * [docs] add the STATIC_URL_PREFIX option Signed-off-by: Jakob Ackermann <das7pad@outlook.com> * [docs] reverse-proxy: nginx: add two setups for STATIC_URL_PREFIX Signed-off-by: Jakob Ackermann <das7pad@outlook.com> * [assets] migrate the url of a new asset to the static url prefix REF: f2a3abc Signed-off-by: Jakob Ackermann <das7pad@outlook.com>

Signed-off-by: jolheiser <john.olheiser@gmail.com>

…b editor) (go-gitea#8590) * Enabling and disabling the commit button to prevent empty commits Signed-off-by: LukBukkit <luk.bukkit@gmail.com> * The button won't get enabled if you change the commit message Signed-off-by: LukBukkit <luk.bukkit@gmail.com> * Fixes a spelling mistake for 'silent' Signed-off-by: LukBukkit <luk.bukkit@gmail.com>

* Fix extra fields from database * Add migration to drop unneeded columns * Fix lint * Make sure the columns exist

…#8642)

* Only attempt to kill parent once * Apply suggestions from code review Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> * Add waitgroup for running servers

Add 'Alt + click' and 'Alt +enter' feature to exclude particular labels on searching for issues.

* Improve OGP * Ensure Repo is loaded when checking Pull info Signed-off-by: jolheiser <john.olheiser@gmail.com>

…access to (go-gitea#8621)

Fix go-gitea#8461 - fix misspelling of {{AppSubUrl}} and other misspelling in template Fixes /explore and organisation redirection

When doing GET /api/v1/users/{user} as an unauthenticated user, gitea throws a 500 because it's trying to dereference elements from the context user. It wants to do this to see whether to show the primary email and will do that if the logged in user is admin or the user in question. However, if ctx.User is nil, go gets really unhappy.

…o-gitea#8655) * Hide some user information via API if user have no enough permission * fix test

lunny · 2019-10-24T12:15:36Z

I think there is a wrong base branch on this PR.

blueworrybear · 2019-10-24T12:17:49Z

@lunny

Humm... it's weird... I'll merge with master in my local workspace and pushagain.

blueworrybear · 2019-10-24T13:18:23Z

I think I mess up my branch... I'll close this PR and recreate a new one. Sorry about that 😭

Gitea and others added 5 commits September 19, 2019 22:42

'update'

70532b8

Merge branch 'master' of https://github.com/go-gitea/gitea

632f267

Send push tag event when release created

b2cfbe1

Merge branch 'master' of https://github.com/go-gitea/gitea

7bae9f3

send tag create event while release created in UI

b15aabd

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 30, 2019

lunny reviewed Sep 30, 2019

View reviewed changes

go.mod Outdated Show resolved Hide resolved

lafriks added the type/bug label Sep 30, 2019

blueworrybear added 3 commits October 1, 2019 23:27

update to go v1.13

15e5ac6

Merge with master, resolve service/release/release.go conflict

3f74da0

fix gofmt error

57146dc

helix84 and others added 15 commits October 2, 2019 02:25

typo fix (go-gitea#8345)

cd1c960

[skip ci] Updated translations via Crowdin

3a7e3db

Update to github.com/lafriks/xormstore@v1.3.0 (go-gitea#8317)

149758c

Change general form binding to gogs form (go-gitea#8334)

bcd4af4

[skip ci] Updated translations via Crowdin

0d93430

Fix a comment typo (go-gitea#8358)

e3eb9fa

[skip ci] Updated translations via Crowdin

3be43dc

Upgrade xorm to v0.7.9 to fix some bugs (go-gitea#8354)

c9f819e

* upgrade xorm to v0.7.9 to fix some bugs * upgrade xormstore to v1.3.1

Fix column name ambiguity in GetUserIssueStats() (go-gitea#8347)

740a0c4

* Add test for FilterModeMention * Fix column name ambiguity * Fix fmt

Fix lfs locks (go-gitea#8361)

0bda876

* Extend time window for TestAPILFSLocksLogged

readd .markdown class to all markup renderers (go-gitea#8357)

9543aea

fixes go-gitea#8299, a regression from 867f46f. unlike it's name suggests, the .markdown class is needed for most markup types. a future refactor should rename this class to something more generic

Cleanup https support code snippet (go-gitea#8370)

6ea7752

GiteaBot and others added 24 commits October 21, 2019 20:22

[skip ci] Updated translations via Crowdin

73f8069

Expose db.SetMaxOpenConns and allow non MySQL dbs to set conn pool pa…

d8161ee

…rams (go-gitea#8528) * Expose db.SetMaxOpenConns and allow other dbs to set their connection params * Add note about port exhaustion Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

Prevent .code-view from overriding font on icon fonts (go-gitea#8614)

2f9a66a

[skip ci] Updated translations via Crowdin

a41a965

Add SubURL to redirect path (go-gitea#8632)

fe41f71

Signed-off-by: jolheiser <john.olheiser@gmail.com>

Fix extra columns from label table (go-gitea#8633)

2f10bfa

* Fix extra fields from database * Add migration to drop unneeded columns * Fix lint * Make sure the columns exist

[skip ci] Updated translations via Crowdin

b4b0e22

Docs: Added instructions for Docker fail2ban configuration. (go-gitea…

c2fca23

…#8642)

[skip ci] Updated translations via Crowdin

7d1a7c0

Graceful fixes (go-gitea#8645)

f067e12

* Only attempt to kill parent once * Apply suggestions from code review Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> * Add waitgroup for running servers

[skip ci] Updated translations via Crowdin

637e321

Add 'Alt + click' feature to exclude labels (go-gitea#8199)

dbd9d8d

Add 'Alt + click' and 'Alt +enter' feature to exclude particular labels on searching for issues.

Improve OGP (go-gitea#8637)

3e61a96

* Improve OGP * Ensure Repo is loaded when checking Pull info Signed-off-by: jolheiser <john.olheiser@gmail.com>

[skip ci] Updated translations via Crowdin

ace0346

Make /users/{username}/repos list private repos the current user has …

22272fe

…access to (go-gitea#8621)

Use AppSubUrl for more redirections (go-gitea#8647)

c84174b

Fix go-gitea#8461 - fix misspelling of {{AppSubUrl}} and other misspelling in template Fixes /explore and organisation redirection

[skip ci] Updated translations via Crowdin

ab791fe

Hide some user information via API if user have no enough permission (g…

bd7709a

…o-gitea#8655) * Hide some user information via API if user have no enough permission * fix test

API should follow RequireSignInView (go-gitea#8654)

3c63c3a

Merge branch 'master' of https://github.com/blueworrybear/gitea

13bf498

blueworrybear closed this Oct 24, 2019

blueworrybear mentioned this pull request Oct 24, 2019

Send tag create and push webhook when release created on UI #8671

Merged

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send tag create and push webhook when release created on UI #8325

Send tag create and push webhook when release created on UI #8325

blueworrybear commented Sep 30, 2019

codecov-io commented Sep 30, 2019 •

edited

Loading

lunny commented Sep 30, 2019

blueworrybear commented Sep 30, 2019

blueworrybear commented Oct 1, 2019

lunny commented Oct 24, 2019

blueworrybear commented Oct 24, 2019

blueworrybear commented Oct 24, 2019

Send tag create and push webhook when release created on UI #8325

Send tag create and push webhook when release created on UI #8325

Conversation

blueworrybear commented Sep 30, 2019

codecov-io commented Sep 30, 2019 • edited Loading

Codecov Report

lunny commented Sep 30, 2019

blueworrybear commented Sep 30, 2019

blueworrybear commented Oct 1, 2019

lunny commented Oct 24, 2019

blueworrybear commented Oct 24, 2019

blueworrybear commented Oct 24, 2019

codecov-io commented Sep 30, 2019 •

edited

Loading