Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make encoding tests independent of LOCALE settings #8018

Merged
merged 10 commits into from
Sep 2, 2019

Conversation

guillep2k
Copy link
Member

@guillep2k guillep2k commented Aug 28, 2019

I've noticed that the encoding tests I've added in #7814 have failed on the drone with an unrelated PR (see this run).

My suspicion is that the drone is running with a LOCALE different from en_US, so this PR is an attempt to make the tests independent from the compilation locale.

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #8018 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8018      +/-   ##
==========================================
+ Coverage   41.57%   41.57%   +<.01%     
==========================================
  Files         480      480              
  Lines       64144    64144              
==========================================
+ Hits        26669    26671       +2     
+ Misses      34015    34013       -2     
  Partials     3460     3460
Impacted Files Coverage Δ
models/repo_indexer.go 64.63% <0%> (-2.04%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
routers/repo/view.go 43.54% <0%> (+1.01%) ⬆️
modules/log/log.go 72.07% <0%> (+2.7%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032c90e...4bd9ed3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2019
@lafriks lafriks added this to the 1.10.0 milestone Aug 28, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2019
@techknowlogick techknowlogick merged commit 6097ff6 into go-gitea:master Sep 2, 2019
@guillep2k guillep2k deleted the charset-test-no-locale branch September 5, 2019 23:17
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants