Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tabs in Makefiles #79

Merged
merged 2 commits into from
Nov 5, 2016
Merged

Use tabs in Makefiles #79

merged 2 commits into from
Nov 5, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 5, 2016

Needed for producing valid Makefiles

@codecov-io
Copy link

codecov-io commented Nov 5, 2016

Current coverage is 2.18% (diff: 100%)

Merging #79 into master will not change coverage

@@            master       #79   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17          

Powered by Codecov. Last update b58b634...6111e09

@lunny
Copy link
Member

lunny commented Nov 5, 2016

Editorconfig should be a customized config. Every repository could derive the default config and can customize one. I don't know if everyone like 8 indent size.

@strk
Copy link
Member Author

strk commented Nov 5, 2016 via email

@strk strk added the type/enhancement An improvement of existing functionality label Nov 5, 2016
@strk strk added this to the 1.0.0 milestone Nov 5, 2016
@metalmatze
Copy link
Contributor

LGTM

1 similar comment
@lunny
Copy link
Member

lunny commented Nov 5, 2016

LGTM

@lunny
Copy link
Member

lunny commented Nov 5, 2016

@tboerger I think lgtm should be configed to ignore MAINTAINERS file.
@metalmatze You have to send a PR to add your name in MAINTAINERS file before you can lgtm.

@tboerger
Copy link
Member

tboerger commented Nov 5, 2016

@tboerger I think lgtm should be configed to ignore MAINTAINERS file.

Than we need to change it within the .lgtm config to simething like NONE.

@tboerger tboerger merged commit ab12596 into go-gitea:master Nov 5, 2016
@strk strk deleted the Makefile-tabs branch November 5, 2016 22:15
@lunny
Copy link
Member

lunny commented Nov 6, 2016

I send a PR to lgtm project go-gitea/lgtm#2 to ignore the MAINTAINERS file.

@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants