Make bindata.go optional, remove from repository #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default will read assets from filesystems, but can embed them by passing the "bindata" build tag (go build -tags bindata) Fixes gogs#77
strk
added
type/enhancement
|
TODO:
|
|
@tboerger if you're ahead of this feel free to discard it, or help is welcome :) |
|
I already said that I'm working on that... |
|
Will it show up in #74, then ? |
Include automatic test for the dynamic "bin"data library
Current coverage is 2.43% (diff: 31.25%)@@ master #78 diff @@
========================================
Files 31 32 +1
Lines 7508 7572 +64
Methods 0 0
Messages 0 0
Branches 0 0
========================================
+ Hits 164 184 +20
- Misses 7327 7368 +41
- Partials 17 20 +3
|
|
Caching was pushed, ready for review (or test if anyone is really on Windows) |
This was referenced Nov 5, 2016
Closed
|
I would close that in favor of the ongoing work done by me as already asked in #78 (comment) |
tboerger
added
reviewed/invalid
issue/duplicate
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default will read assets from filesystems, but can embed them
by passing the "bindata" build tag (go build -tags bindata)
Fixes #77