Clean up ref name rules #6437
Merged
Clean up ref name rules #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up checks on reference names to better conform to the guideline here: https://git-scm.com/docs/git-check-ref-format This fixes half of go-gitea#6321
According to: https://git-scm.com/docs/git-check-ref-format And: git check-ref-format "master/feature=test1" This is a valid branch name and we should not be testing for it to fail.
lafriks
approved these changes
Mar 26, 2019
GiteaBot
added
the
lgtm/need 1
adelowo
approved these changes
Mar 26, 2019
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #6437 +/- ##
==========================================
- Coverage 38.85% 38.85% -0.01%
==========================================
Files 365 365
Lines 51413 51414 +1
==========================================
- Hits 19978 19977 -1
- Misses 28566 28568 +2
Partials 2869 2869
Continue to review full report at Codecov.
|
|
Please send backport to release v1.7 and v1.8 branches |
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this pull request
Mar 26, 2019
* Clean up ref name rules Clean up checks on reference names to better conform to the guideline here: https://git-scm.com/docs/git-check-ref-format This fixes half of go-gitea#6321 * Update branch create integration test According to: https://git-scm.com/docs/git-check-ref-format And: git check-ref-format "master/feature=test1" This is a valid branch name and we should not be testing for it to fail.
techknowlogick
added
the
backport/done
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this pull request
Mar 26, 2019
* Clean up ref name rules Clean up checks on reference names to better conform to the guideline here: https://git-scm.com/docs/git-check-ref-format This fixes half of go-gitea#6321 * Update branch create integration test According to: https://git-scm.com/docs/git-check-ref-format And: git check-ref-format "master/feature=test1" This is a valid branch name and we should not be testing for it to fail.
zeripath
pushed a commit
that referenced
this pull request
Mar 26, 2019
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up checks on reference names to better conform to the guideline
here: https://git-scm.com/docs/git-check-ref-format
This fixes half of #6321
To see example of current problem, just try and create a branch or tag with a valid name containing allowed special characters like
test+me. It will incorrectly sayTagName must be a well-formed Git reference nameI've tried to add several extra tests as well since if a bad name gets by this check it can later through a less friendly 500 error if we try to create a branch with a bad name