-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify linkRegex to require http|https #6171
Conversation
Modify the current linkRegex to require http|https which appears to be the intended behavior based on the comments. Right now, it also matches anything starting with www as well. Also add testing for linkRegex
Codecov Report
@@ Coverage Diff @@
## master #6171 +/- ##
==========================================
- Coverage 38.86% 38.85% -0.01%
==========================================
Files 354 354
Lines 50210 50210
==========================================
- Hits 19514 19510 -4
- Misses 27869 27874 +5
+ Partials 2827 2826 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve, as leaving the broken autolinker for www.* in is of no use whatsoever.
Is this a break change? |
Well the current situation is that the auto links to say www.google.com just don't work and have never worked. |
So this should be back port to release/v1.7 |
Please send back port to release/v1.7 |
Ugh sorry this is the same as #6153 which I broke by deleting my branch (which github didn't like)
Anyway, this is the same request to modify linkRegex so it only matches text starting with http|https when creating links. I've also added the requested tests for this to the current test suite as well.