Fix #4877 to follow the OpenID Connect Audiences spec #4878

OvermindDL1 · 2018-09-06T05:37:30Z

This follows the OpenID Connect spec to support audiences with either a string or an array of strings instead of just a string.

This might want to be on the release branches as well as it is a bug fix, but I personally can use master until then.

I have tested this and am running it on my site now with the OpenID Connect with multiple audiences returned with no issue, the new code is not even run at all unless the old pure-string check fails.

Disclaimer: I've never used and barely looked at Go thus far, and I was unable to find common functions like filter or so forth (or any higher order functions at all...) and based on some googling it appears that these large and unwieldy loops are the standard way to do this kind of thing in Go, but if any changes are needed please request as such with information on what I should change it to (great learning opportunity!).

And of course any rights or whatever there-of related to this code I give up for whatever use this project currently wants or will want in the future. Etc... etc... Commit is signed, etc...

This follows the OpenID Connect spec to support audiences with either a string or an array of strings instead of just a string. Signed-off-by: Gabriel Robertson <overminddl1@gmail.com>

OvermindDL1 · 2018-09-06T05:41:26Z

No clue why the CI failed, it looks like it didn't even try to recompile this code... o.O

lunny · 2018-09-06T06:15:42Z

@OvermindDL1 You have to send a PR to upstream repo github.com/markbates/goth and then push this one again.

OvermindDL1 · 2018-09-06T14:48:04Z

@lunny Interesting. Why is the dependency included 'inside' this repo if it is not actually code for this project itself? (I'm learning the reasonings as I've never seen someone include the dependents directly in a project short of ancient C and Cobol work 30 years ago...).

What do you mean by push this again, as in push the entire 'goth' repo into it, as a git submodule, with a .git directory, without a .git directory (archived), etc...? In anything from C++ to the JVM to many others I'm used to just updating a single reference in a single file to pull a new version of a dependent, thus including the entire dependent in the repo itself is extremely foreign to me (seems inefficient but I'm guessing there is a reason?) so I want to make sure I am doing it properly. ^.^;

OvermindDL1 · 2018-09-06T14:57:42Z

PR submitted: markbates/goth#240

lunny · 2018-09-07T01:43:05Z

@OvermindDL1 We don't want to maintain all the dependency libraries so we will always follow the upstream library's update. If some commit changed the dependency library directly, that maybe make the things more complexly in future.
I'm sorry I mean after upstream PR merged, you could run dep ensure -update github.com/markbates/goth and then commit and push. We use github.com/golang/dep to manage dependency libraries.
Thank you for your effort.

OvermindDL1 · 2018-09-07T14:29:01Z

Makes sense, I did not know that the go style is to copy all dependencies into a vendor directory (seems like that would artificially inflate a repository size, a substantial amount...) so didn't know it had any special significance. I've not seen a language copy in it's dependencies permanently since my old C/Cobal days 25 years ago so it was entirely unexpected for me. ^.^;

Care if this is left open as a reminder for me when the goth PR gets submitted, the instructions you gave should be great for me to use at that time. :-)

OvermindDL1 · 2018-09-19T15:00:35Z

And markbates/goth#240 was just merged, the goth dependency can now be updated. :-)

I'm trying to do it myself, but I had to deal with some horror of GOPATH environment variable just to get rid of some message that it didn't know what gopath was, and no gopath worked except for putting gitea in a directory named 'src' for whatever reason, and all that does is print out nothing but this, no matter how I run it, try to update it, verify it, anything:

# dep ensure -update github.com/markbates/goth
dep: WARNING: Unknown field in manifest: prune
The following errors occurred while deducing packages:
  * "code.gitea.io/gitea/modules/highlight": unable to deduce repository and source type for "code.gitea.io/gitea/modules/highlight": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/mailer": unable to deduce repository and source type for "code.gitea.io/gitea/modules/mailer": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/markup/external": unable to deduce repository and source type for "code.gitea.io/gitea/modules/markup": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/process": unable to deduce repository and source type for "code.gitea.io/gitea/modules/process": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/public": unable to deduce repository and source type for "code.gitea.io/gitea/modules/public": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/models": unable to deduce repository and source type for "code.gitea.io/gitea/models": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/base": unable to deduce repository and source type for "code.gitea.io/gitea/modules/base": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/setting": unable to deduce repository and source type for "code.gitea.io/gitea/modules/setting": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/user": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/httplib": unable to deduce repository and source type for "code.gitea.io/gitea/modules/httplib": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/indexer": unable to deduce repository and source type for "code.gitea.io/gitea/modules/indexer": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/pprof": unable to deduce repository and source type for "code.gitea.io/gitea/modules/pprof": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1/org": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1/swagger": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/org": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/test": unable to deduce repository and source type for "code.gitea.io/gitea/modules/test": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/minwinsvc": unable to deduce repository and source type for "code.gitea.io/gitea/modules/minwinsvc": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1/misc": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1/utils": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/templates": unable to deduce repository and source type for "code.gitea.io/gitea/modules/templates": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/auth": unable to deduce repository and source type for "code.gitea.io/gitea/modules/auth": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/auth/pam": unable to deduce repository and source type for "code.gitea.io/gitea/modules/auth": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/search": unable to deduce repository and source type for "code.gitea.io/gitea/modules/search": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1/convert": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/auth/oauth2": unable to deduce repository and source type for "code.gitea.io/gitea/modules/auth": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/context": unable to deduce repository and source type for "code.gitea.io/gitea/modules/context": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1/user": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/user": unable to deduce repository and source type for "code.gitea.io/gitea/modules/user": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/validation": unable to deduce repository and source type for "code.gitea.io/gitea/modules/validation": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/notification": unable to deduce repository and source type for "code.gitea.io/gitea/modules/notification": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/recaptcha": unable to deduce repository and source type for "code.gitea.io/gitea/modules/recaptcha": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/private": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/markup": unable to deduce repository and source type for "code.gitea.io/gitea/modules/markup": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/sync": unable to deduce repository and source type for "code.gitea.io/gitea/modules/sync": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/utils": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/models/migrations": unable to deduce repository and source type for "code.gitea.io/gitea/models": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/generate": unable to deduce repository and source type for "code.gitea.io/gitea/modules/generate": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/markup/markdown": unable to deduce repository and source type for "code.gitea.io/gitea/modules/markup": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/private": unable to deduce repository and source type for "code.gitea.io/gitea/modules/private": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/admin": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1/admin": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/util": unable to deduce repository and source type for "code.gitea.io/gitea/modules/util": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/auth/openid": unable to deduce repository and source type for "code.gitea.io/gitea/modules/auth": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/cron": unable to deduce repository and source type for "code.gitea.io/gitea/modules/cron": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/lfs": unable to deduce repository and source type for "code.gitea.io/gitea/modules/lfs": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/ssh": unable to deduce repository and source type for "code.gitea.io/gitea/modules/ssh": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/dev": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/avatar": unable to deduce repository and source type for "code.gitea.io/gitea/modules/avatar": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/api/v1/repo": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/repo": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/options": unable to deduce repository and source type for "code.gitea.io/gitea/modules/options": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/user/setting": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/auth/ldap": unable to deduce repository and source type for "code.gitea.io/gitea/modules/auth": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/cache": unable to deduce repository and source type for "code.gitea.io/gitea/modules/cache": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/modules/log": unable to deduce repository and source type for "code.gitea.io/gitea/modules/log": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found
  * "code.gitea.io/gitea/routers/routes": unable to deduce repository and source type for "code.gitea.io/gitea/routers": unable to read metadata: go-import metadata not found

validateParams: could not deduce external imports' project roots

What am I doing wrong here... I'm used to just updating some commit in some dependency file and running something like cmake .. or mix deps.get or cargo build and google is not being helpful talking about private repo's or whatever so I feel like I have to be doing something really wrong... :-(

lafriks · 2018-09-19T16:10:14Z

I will look into this later when I get home

OvermindDL1 · 2018-09-19T16:28:52Z

I will look into this later when I get home

Cool thanks, I'd love to know what I'm doing wrong so I will know how to do it properly in the future. :-)

lafriks · 2018-09-20T04:38:43Z

Command is correct. Might be you have old golang dep version. Did you try to:

go get -u github.com/golang/dep/cmd/dep

codecov-io · 2018-09-20T04:58:28Z

Codecov Report

❗ No coverage uploaded for pull request base (master@364c029). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #4878   +/-   ##
========================================
  Coverage          ?   37.4%           
========================================
  Files             ?     306           
  Lines             ?   45334           
  Branches          ?       0           
========================================
  Hits              ?   16959           
  Misses            ?   25922           
  Partials          ?    2453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 364c029...c7872ca. Read the comment docs.

OvermindDL1 · 2018-09-20T14:36:50Z

Command is correct. Might be you have old golang dep version. Did you try to:

No clue? It was installed via asdf and it returns:

╰─➤  go version         
go version go1.11 linux/amd64

And generally asdf is up-to-date? Plus, if anything was out of date shouldn't it state to update due to a version check with the internal metadata of the project when ran (at least that is how cmake/mix/cargo/etc all work)?

EDIT: Oh, and this is the first time I've ever installed golang, so no prior installations either.

lafriks · 2018-09-20T19:05:05Z

@OvermindDL1 it is not about GoLang but dep tool. It is hard to tell why it was not working for you

lafriks · 2018-09-20T19:06:30Z

I will move to 1.6.0 milestone as it is just dependency update

Prepare for wild/v1.6 branch * BREAKING * Respect email privacy option in user search via API (go-gitea#4512) * Simply remove tidb and deps (go-gitea#3993) * Swagger.v1.json template (go-gitea#3572) * FEATURE * Pull request review/approval and comment on code (go-gitea#3748) * Added dependencies for issues (go-gitea#2196) (go-gitea#2531) * Add the ability to have built in themes in Gitea and provide dark theme arc-green (go-gitea#4198) * Add sudo functionality to the API (go-gitea#4809) * Add oauth providers via cli (go-gitea#4591) * Disable merging a WIP Pull request (go-gitea#4529) * Force user to change password (go-gitea#4489) * Add letsencrypt to Gitea (go-gitea#4189) * Add push webhook support for mirrored repositories (go-gitea#4127) * Add csv file render support defaultly (go-gitea#4105) * Add Recaptcha functionality to Gitea (go-gitea#4044) * BUGFIXES * Fix release creation via API (go-gitea#5076) * Remove links from topics in edit mode (go-gitea#5026) * Fix missing AppSubUrl in few more templates (fixup) (go-gitea#5021) * Fix missing AppSubUrl in some templates (go-gitea#5020) * Hide outdated comments in file view (go-gitea#5017) * Upgrade gopkg.in/testfixtures.v2 (go-gitea#4999) * Disable debug routes unless PPROF is enabled in configuration (go-gitea#4995) * Fix user menu item styling (go-gitea#4985) * Fix layout of the topics editing form (go-gitea#4971) * Fix null pointer dereference in ParseCommitWithSignature (go-gitea#4962) * Fix url in discord webhook (go-gitea#4953) * Detect charset and convert non UTF-8 files for display (go-gitea#4950) * Make sure to catch the right error so it is displayed on the UI (go-gitea#4945) * Fix(topics): don't redirect to explore page. (go-gitea#4938) * Fix bug forget to remove Stopwatch when remove repository (go-gitea#4928) * Fix bug when repo remained bare if multiple branches pushed in single push (go-gitea#4923) * Fix: Let's Encrypt configuration settings (go-gitea#4911) * Fix: Crippled diff (go-gitea#4726) (go-gitea#4900) * Fix trimming of markup section names (go-gitea#4863) * Issues api allow pulls and fix go-gitea#4832 (go-gitea#4852) * Do not autocreate directory for new users/orgs (go-gitea#4828) (go-gitea#4849) * Fix redirect with non-ascii branch names (go-gitea#4764) (go-gitea#4810) * Fix missing release title in webhook (go-gitea#4783) (go-gitea#4796) * User shouldn't be able to approve or reject his/her own PR (go-gitea#4729) * Make sure to reset commit count in the cache on mirror syncing (go-gitea#4720) * Fixed bug where team with admin privelege type doesn't get any unit (go-gitea#4719) * Fix incorrect caption of webhook setting (go-gitea#4701) (go-gitea#4717) * Allow WIP marker to contains < or > (go-gitea#4709) * Hide org/create menu item in Dashboard if user has no rights (go-gitea#4678) (go-gitea#4680) * Site admin could create repos even MAX_CREATION_LIMIT=0 (go-gitea#4645) * Fix custom templates being ignored (go-gitea#4638) * Fix starring icon after semantic ui update (go-gitea#4628) * Fix Split-View line adjustment (go-gitea#4622) * Fix integer constant overflows in tests (go-gitea#4616) * Push whitelist now doesn't apply to branch deletion (go-gitea#4601) (go-gitea#4607) * Fix bugs when too many IN variables (go-gitea#4594) * Fix failure on creating pull request with assignees (go-gitea#4419) (go-gitea#4583) * Fix panic issue on update avatar email (go-gitea#4580) (go-gitea#4581) * Fix status code label for a successful webhook (go-gitea#4540) * An inactive user shouldn't be able to be added as a collaborator (go-gitea#4535) * Don't fail silently if trying to add a collaborator twice (go-gitea#4533) * Fix incorrect MergeWhitelistTeamIDs check in CanUserMerge function (go-gitea#4519) (go-gitea#4525) * Fix out-of-transaction query in removeOrgUser (go-gitea#4521) (go-gitea#4522) * Fix migration from older releases (go-gitea#4495) * Accept 'Data:' in commit graph (go-gitea#4487) * Update xorm to latest version and fix correct `user` table referencing in sql (go-gitea#4473) * Relative URLs for LibreJS page (go-gitea#4460) * Redirect to correct page after using scratch token (go-gitea#4458) * Fix column droping for MSSQL that need new transaction for that (go-gitea#4440) * Replace src with raw to fix image paths (go-gitea#4377) * Add default merge options when creating new repository (go-gitea#4369) * Fix docker build (go-gitea#4358) * Fixes repo membership check in API (go-gitea#4341) * Dep upgrade mysql lib (go-gitea#4161) * Fix some issues with special chars in branch names (go-gitea#3767) * Responsive design fixes (go-gitea#4508) * ENHANCEMENT * Fix milestones sorted wrongly (go-gitea#4987) * Allow api to create tags for releases if they don't exist (go-gitea#4890) * Fix go-gitea#4877 to follow the OpenID Connect Audiences spec (go-gitea#4878) * Enforce token on api routes [fixed critical security issue go-gitea#4357] (go-gitea#4840) * Update legacy branch and tag URLs in dashboard to new format (go-gitea#4812) * Slack webhook channel name cannot be empty or just contain an hashtag (go-gitea#4786) * Add whitespace handling to PR-comparsion (go-gitea#4683) * Make reverse proxy auth optional (go-gitea#4643) * MySQL TLS (go-gitea#4642) * Make sure to set PR split view when creating/previewing a pull request (go-gitea#4617) * Log user in after a successful sign up (go-gitea#4615) * Fix typo IsPullReuqestBroken -> IsPullRequestBroken (go-gitea#4578) * Allow admin toggle forcing a password change for newly created users (go-gitea#4563) * Update jQuery to v1.12.4 (go-gitea#4551) * Env var GITEA_PUSHER_EMAIL (go-gitea#4516) * Feat(repo): support search repository by topic name (go-gitea#4505) * Small improvements to dependency UI (go-gitea#4503) * Make max commits in graph configurable (go-gitea#4498) * Add valid for lfs oid (go-gitea#4461) * Add shortcut to save wiki page (go-gitea#4452) * Allow administrator to create repository for any organization (go-gitea#4368) * Fix repository last updated time update when delete a user who watched the repo (go-gitea#4363) * Switch plaintext scratch tokens to use hash instead (go-gitea#4331) * Increase default TOTP secret size to 320 bits (go-gitea#4287) * Keep preseeded database password (go-gitea#4284) * Implemented hover text showing user FullName (go-gitea#4261) * Add ability to delete a token (go-gitea#4235) * Fix typos in i18n variable names. (go-gitea#4080) * Api: repos/search: add parameters to control the sort order (go-gitea#3964) * Add missing path in the Docker app.ini template (go-gitea#2181) * Add file name and branch to page title (go-gitea#4902) * Offline use of google fonts (go-gitea#4872) * Add missing History link to directory listings v2 (go-gitea#4829) * Locale for Edit and Remove due date issue (go-gitea#4802) * Disable 'May Import Local Repository' when is disabled by setting (Is… (go-gitea#4780) * API /admin/users/{username} missing parameter (go-gitea#4775) * Display error when adding a user to a team twice (go-gitea#4746) * Remove UsePrivilegeSeparation from the Docker sshd_config, see go-gitea#2876 (go-gitea#4722) * Focus title input when clicking helper link (go-gitea#4696) * Add vendor to user reserved words and format words list according alphabet (go-gitea#4685) * Add gitea/issues link to 500 page (go-gitea#4654) * Hide home button when landing page is not set to home (go-gitea#4651) * Remove link to GitHub issues in 404 template (go-gitea#4639) * Cmd/serve: pprof cpu and memory profile dumps to disk (go-gitea#4560) * Add flash message after an account has been successfully activated (go-gitea#4510) * Prevent html entity escaping on delete branch (go-gitea#4471) * Locale for button Edit on protected branch (go-gitea#4442) * Update notification icon (go-gitea#4343) * Added front-end topics validation (go-gitea#4316) * Don't display buttons if there are no system notifications (go-gitea#4280) * Issue due date api (go-gitea#3890) * SECURITY * Improve URL validation for external wiki and external issues (go-gitea#4710) * Make cookies HttpOnly and obey COOKIE_SECURE flag (go-gitea#4706) * Don't disclose emails of all users when sending out emails (go-gitea#4664) * Check that repositories can only be migrated to own user or organizations (go-gitea#4366) * TRANSLATION * Fix punctuation in English translation (go-gitea#4958) * Fix translation (go-gitea#4355)

Fix go-gitea#4877 to follow the OpenID Connect Audiences spec

1010a88

This follows the OpenID Connect spec to support audiences with either a string or an array of strings instead of just a string. Signed-off-by: Gabriel Robertson <overminddl1@gmail.com>

bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2018

lunny added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Sep 6, 2018

OvermindDL1 mentioned this pull request Sep 6, 2018

Follow the OpenID Connect Audiences spec markbates/goth#240

Merged

jonasfranz added type/enhancement An improvement of existing functionality and removed status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Sep 18, 2018

jonasfranz added this to the 1.7.0 milestone Sep 18, 2018

jonasfranz added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Sep 18, 2018

lafriks added 2 commits September 20, 2018 07:45

Update goth dependency

6db8b26

Merge branch 'master' into patch-1

b3332e2

lafriks approved these changes Sep 20, 2018

View reviewed changes

bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2018

techknowlogick approved these changes Sep 20, 2018

View reviewed changes

bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 20, 2018

lafriks removed this from the 1.7.0 milestone Sep 20, 2018

lafriks added this to the 1.6.0 milestone Sep 20, 2018

lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Sep 20, 2018

Merge branch 'master' into patch-1

c7872ca

lafriks merged commit 07af31d into go-gitea:master Sep 20, 2018

lafriks added the type/changelog Adds the changelog for a new Gitea version label Nov 10, 2018

go-gitea locked and limited conversation to collaborators Nov 24, 2020

delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #4877 to follow the OpenID Connect Audiences spec #4878

Fix #4877 to follow the OpenID Connect Audiences spec #4878

OvermindDL1 commented Sep 6, 2018 •

edited

Loading

OvermindDL1 commented Sep 6, 2018 •

edited

Loading

lunny commented Sep 6, 2018

OvermindDL1 commented Sep 6, 2018 •

edited

Loading

OvermindDL1 commented Sep 6, 2018

lunny commented Sep 7, 2018

OvermindDL1 commented Sep 7, 2018

OvermindDL1 commented Sep 19, 2018 •

edited

Loading

lafriks commented Sep 19, 2018

OvermindDL1 commented Sep 19, 2018

lafriks commented Sep 20, 2018

codecov-io commented Sep 20, 2018 •

edited

Loading

OvermindDL1 commented Sep 20, 2018 •

edited

Loading

lafriks commented Sep 20, 2018

lafriks commented Sep 20, 2018

Fix #4877 to follow the OpenID Connect Audiences spec #4878

Fix #4877 to follow the OpenID Connect Audiences spec #4878

Conversation

OvermindDL1 commented Sep 6, 2018 • edited Loading

OvermindDL1 commented Sep 6, 2018 • edited Loading

lunny commented Sep 6, 2018

OvermindDL1 commented Sep 6, 2018 • edited Loading

OvermindDL1 commented Sep 6, 2018

lunny commented Sep 7, 2018

OvermindDL1 commented Sep 7, 2018

OvermindDL1 commented Sep 19, 2018 • edited Loading

lafriks commented Sep 19, 2018

OvermindDL1 commented Sep 19, 2018

lafriks commented Sep 20, 2018

codecov-io commented Sep 20, 2018 • edited Loading

Codecov Report

OvermindDL1 commented Sep 20, 2018 • edited Loading

lafriks commented Sep 20, 2018

lafriks commented Sep 20, 2018

OvermindDL1 commented Sep 6, 2018 •

edited

Loading

OvermindDL1 commented Sep 6, 2018 •

edited

Loading

OvermindDL1 commented Sep 6, 2018 •

edited

Loading

OvermindDL1 commented Sep 19, 2018 •

edited

Loading

codecov-io commented Sep 20, 2018 •

edited

Loading

OvermindDL1 commented Sep 20, 2018 •

edited

Loading