-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User shouldn't be able to approve or reject his/her own PR #4729
Merged
jonasfranz
merged 11 commits into
go-gitea:master
from
adelowo:cannot_approve_or_reject_your_own_pr
Aug 20, 2018
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8951891
Make sure author cannot reject/approve their own PR
adelowo 4bb258c
Disable buttons in templates too
adelowo 27e5587
Remove unneccessary if check since the switch below catches it
adelowo 7e7454c
Merge branch 'master' of https://github.com/go-gitea/gitea into canno…
adelowo 55edbc3
Fix IsOwner check
adelowo 9f86967
Update template and remove new template variable
adelowo 3b019d8
Merge branch 'master' into cannot_approve_or_reject_your_own_pr
adelowo 2a4a5fc
Add alert template and redirect to diff page on review failure
adelowo 654daad
Redirect to files diff as a little update to #4632
adelowo f39a834
Merge branch 'cannot_approve_or_reject_your_own_pr' of github.com:ade…
adelowo 67989c9
Merge branch 'master' into cannot_approve_or_reject_your_own_pr
adelowo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please redirect to
%s/pulls/%d/files
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
base/alert
template isn't imported in the template for the page%s/pulls/%d/files
which is why I redirected back to the main page... Should I just add the alert template in there or just leave it as it is ? ( #4632 redirects to the main PR page though )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add alert to to files template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed @JonasFranzDEV and @lafriks