Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code.gitea.io/git #3137

Merged
merged 3 commits into from
Dec 11, 2017
Merged

Update code.gitea.io/git #3137

merged 3 commits into from
Dec 11, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Dec 10, 2017 •
edited
Loading

Updates code.gitea.io/git dependency. Includes go-gitea/git#91, among other PRs.

@lafriks
Copy link
Member

lafriks commented Dec 10, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 10, 2017
@lafriks
Copy link
Member

lafriks commented Dec 10, 2017

/offtopic why drone tests still conflict with each other? :(

@sapk
Copy link
Member

sapk commented Dec 10, 2017 •
edited
Loading

Trusted LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2017
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 10, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 10, 2017
@codecov-io
Copy link

codecov-io commented Dec 11, 2017 •
edited
Loading

Codecov Report

Merging #3137 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3137      +/-   ##
==========================================
- Coverage   34.85%   34.83%   -0.02%     
==========================================
  Files         275      275              
  Lines       40030    40030              
==========================================
- Hits        13951    13946       -5     
- Misses      24084    24087       +3     
- Partials     1995     1997       +2
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/ssh_key.go 31.92% <0%> (-0.74%) ⬇️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682ac11...8c3a121. Read the comment docs.

@lunny
Copy link
Member

lunny commented Dec 11, 2017

make L-G-T-M work

@lunny lunny merged commit 58a7de2 into go-gitea:master Dec 11, 2017
@ethantkoenig ethantkoenig deleted the update/git branch December 15, 2017 18:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ethantkoenig @lafriks @sapk @codecov-io @lunny @tboerger